Skip to content
Snippets Groups Projects

SPHN Connector code improvements

Merged Nicola Stoira requested to merge sphnc-872 into main

Main changes:

  • List vertically methods parameters if the method has more than 5 arguments or if the list looks too long
  • Update old docstrings for methods and update missing parameters
  • Remove f strings without parameters
  • Always use except Exception instead of only except

If you think that's enough also for this task https://git.dcc.sib.swiss/sphn-semantic-framework/workingfair/-/issues/267 let me know and I can close that one as well. Personally, I would not go too much into details otherwise we will never stop improving the code :)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading